Skip to content

Upgrade restate-sdk-shared-core to 8.4.0 - #16

Merged
igalshilman merged 2 commits into
mainfrom
claude/shared-core-8.4.0
Nov 9, 2026
Merged

igalshilman merged 2 commits into
mainfrom
claude/shared-core-8.4.0

Conversation

@igalshilman

Copy link
Copy Markdown
Collaborator

The native addon now depends on the released restate-sdk-shared-core 8.4.0 from crates.io, with the sql feature. It used to depend on the sessions-storage git branch, which no longer exists. 8.4.0 includes the storage and SQL, and also the plain read-through cache with unique tail entry names (#113).

Only native/Cargo.toml and native/Cargo.lock change, and no code has to change.

Locally:

  • cargo build is clean.
  • cargo clippy --all-targets -D warnings is clean.
  • vitest with the release addon gives 127 passed.
  • With a debug addon, a long statement lets the event loop run times out at 5s, which is debug-build speed.

Generated by Claude Code

…e sessions-storage branch

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Once this release writes an SH23 state head, the previous addon cannot read it, so rolling back can make persisted session state unavailable. Please resolve the downgrade and rollback compatibility path before merging.

Reviewed changes — I reviewed the native crate dependency switch from the sessions-storage git branch to the released restate-sdk-shared-core 8.4.0 package and its lockfile update.

  • Shared-core dependency source — The native crate now resolves the sql feature from crates.io, with the lockfile updated to the registry package and checksum.

Important

This run used your free trial credits ($9.98 of $10 left) on GPT Luna, a fast, lightweight model. Connect a provider → to run the model you choose.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6-luna (free trial credits) | 𝕏

Comment thread packages/sessions/native/Cargo.toml Outdated
# branch until a release with them is out.
restate-sdk-shared-core = { git = "https://github.com/restatedev/sdk-shared-core", branch = "sessions-storage", features = [
# The storage (`state`) and SQL on it (`sql`), with its feature `sql`.
restate-sdk-shared-core = { version = "8.4.0", features = [

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared-core 8.4.0 writes SH23 state heads that older versions cannot read, so reverting this addon after it has written one can make existing session state unavailable. Please keep the new format rollback-compatible or define an explicit migration/deployment constraint before adopting this release.

Technical details
# Downgrade cannot read persisted state

## Affected sites
- `packages/sessions/native/Cargo.toml:18` — selects shared-core 8.4.0, which introduces SH23 heads; its [release comparison](https://github.com/restatedev/sdk-shared-core/compare/v8.3.1...v8.4.0) states older SDKs cannot read them.

## Required outcome
- Ensure persisted session state remains recoverable by the previous addon version, or establish a migration and deployment policy that prevents rollback after SH23 state is written.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right: SH23 heads only go forward. The format change was decided in sdk-shared-core#113, whose commit message says "Older SDKs can't read SH23 heads; no compatibility release at this point." 8.4.0 still reads SH22 heads, so upgrading is safe. Only a rollback after a flush can't read the new heads.

This PR can't add a compatibility path, because it would have to go into an older shared core. So the PR stays as it is, and I've raised the rollback constraint with the maintainer.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@igalshilman
igalshilman merged commit 159d483 into main Nov 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants